Fix SSH task collection folder removal upon failure #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark comparisonGET /api/alive/
GET /api/v2/dataset/
GET /api/v2/job/
GET /api/v2/project/
GET /api/v2/workflow/
POST /api/v2/project/3/dataset/404/images/query/
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
|
Note that renaming a venv folder breaks its |
|
For the record $ python -m venv MYVENV
$ grep -n MYVENV MYVENV/bin/*
MYVENV/bin/activate:41:VIRTUAL_ENV="/tmp/MYVENV"
MYVENV/bin/activate:58: PS1="(MYVENV) ${PS1:-}"
MYVENV/bin/activate:60: VIRTUAL_ENV_PROMPT="(MYVENV) "
MYVENV/bin/activate.csh:11:setenv VIRTUAL_ENV "/tmp/MYVENV"
MYVENV/bin/activate.csh:20: set prompt = "(MYVENV) $prompt"
MYVENV/bin/activate.csh:21: setenv VIRTUAL_ENV_PROMPT "(MYVENV) "
MYVENV/bin/activate.fish:36:set -gx VIRTUAL_ENV "/tmp/MYVENV"
MYVENV/bin/activate.fish:59: printf "%s%s%s" (set_color 4B8BBE) "(MYVENV) " (set_color normal)
MYVENV/bin/activate.fish:68: set -gx VIRTUAL_ENV_PROMPT "(MYVENV) "
MYVENV/bin/pip:1:#!/tmp/MYVENV/bin/python3
MYVENV/bin/pip3:1:#!/tmp/MYVENV/bin/python3
MYVENV/bin/pip3.10:1:#!/tmp/MYVENV/bin/python3 |
Fixed with 2acff13, by moving to a more explicit strategy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1633
Checklist before merging
CHANGELOG.mdmaininto the current branch.